Not a bad piece of advice, but isn't it a bit rude to just say "lern2draw" to someone who's trying to learn to draw? Anyways, i might as well try to offer some pointers:

The outer side of the cup is decent enough, if a bit smudgy. However, you missed a little detail about cups and other hollow cylinders; the inner side of it DOES NOT have shadows in the same place as the outer side. I happen to have a shoddy example of what i mean. Notice how the shadow inside the cup is on the opposite side of the shadow on the outer side.

Also, in your drawing, the shadow from the cup FALLS TOWARDS THE LIGHT. Shadows don't work like that, i'm afraid. They always point directly away from the light, full stop. The length of the shadow then depends on the height of the light source and the angle of the surface that the shadow is falling on, but mostly you can get away with winging it.

The texture on the table is also very obviously looped. Ideally, if you do have to loop a texture, it shouldn't be evident.

Besides that, it's mostly just a matter of practicing your stuff. I know it's the most ubiquitous advice ever, but it's sadly(?) the only way to get better at drawing.