It'll be interesting to see a Trump supporter's point of view on this and I hope we have one.
1. Was Trump right to impose the ban - Well he's the commander in chief, so he certainly in that regard has the authority. But no, I don't think he's right to do this ban. And it's not even fully practiced, we have people in the military of all branches say "I don't care what he said, I'm not imposing that."
So if you're telling me the government is banning people for this problem and that problem when it comes to depression and other non-psychotic mental illnesses, I want to hear what are they doing about our current soldiers. Because they are turning the most healthiest of men and women into manic depressive suicidal patients anyways. Yes its a risk, but maybe this will help fund the mental health support they clearly need in the branches anyways.
My counter to that Ele is we need to consider why transgender people kill themselves. Shot in the dark - I'd imagine they can't get their gender reassignment surgery, and are generally treated as 2nd class citizens.
The military already pays for ancillary surgeries with a certain amount of commitment (I think it's 3 years?), and well, it doesn't help someone's cause when their country says you're not good enough to defend our freedoms.
Gender reassignment surgery being paid for by the military is a difficult prospect, but not unobtainable. If we're going to spend as much as we do on defense spending, might as well take a moral high ground on a subject like this. From what I've been told, you can already get breast augmentation on the military dime.
I think it's fair to say that yes we need tons more research; however, it's still wrong in my mind to suppress minority because of... statistics. We're talking about every transgendered person and placing this blanket statement that they have more mental problems and higher suicide rates.
They do have higher rates of suicide. This is fact. Nothing wrong with that, ain't a 'hate fact' as some extremists would say it is. No need to liken me to a car insurance salesman..
Anyway, my point has always been that we should not accept suicidal people into the military, not that we shouldn't accept transgendered people - So what's the issue?

1.) Urinalysis drug testing is often done once a month. When drug tested, you have an observer of the same sex watch you give your sample. Now, knowing you can "identify" as a female but still not have gone through the actual surgical procedure, means you can be a male, with a penis, identifying as a female, being observed by a female.
Ask them who they are confident being observed by.
2.) Showering in the field: When deployed or in a field training exercise, you will shower with that of the same sex. Scenario: Male identifying as a female, but still hasn't undergone surgical procedures (still has a penis), would be showering with females. Keep in mind, a 3rd shower group for transgenders is called segregation.
It might be segregation, but transgender bathrooms exist and the LGBT community is actively campaigning for more. If those are becoming a reality, why cant you let transgender people shower together? Or just shower with whatever gender they feel comfortable.
3.) PT Tests, or physical fitness tests: These have to be done at least once every 6 months, (at least for the Army). For those that don't know, these tests are scored differently by sex. Females have lower score requirements than males. What if a male identified as a female solely to score a 300 (Max score)? Also: females are exempt from PT tests if pregnant, but what if a transgender female, now a male, got pregnant?
This isn't really an issue. If a transgender male became pregnant then surely they would get the same exemptions, unless of course they didn't want them. As for the scoring, they should choose. If they were born female, but wish to take the harder tests for males, then so be it.
4.) Deployment: similar to issue 3, females are undeployable if pregnant, but what if a transgender female, now a male, got pregnant?
Same answer as 3. They would get the same exemptions, as they too are also pregnant.
5.) AR 670-1 (appearance regulation article). This is the article that says males have to shave, have tapered hair cuts, tattoo regulation, etc. For example: Imagine a transgender male, now a female, growing facial hair. Who would tell her to shave her face?
If they identify as a male, and are in the male section of the army then they should adhere to all the disciplinary procedures like everyone else. I'm sure they will be okay with that.
6.) Lodging is separate for males and females when in training. See issue 2.
Once again, either establish another lodge or allow them to bunk with whatever gender they identify with.